-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary data and json test #1599
Conversation
Go tests are failing which is not related. |
7fd2123
to
793bba9
Compare
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
This new file comes from: https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt It is licensed under CC BY 4.0. After discussing that with its author, I think it is ok to add it as is to our repository. The only restriction might be that we should indicate in the file any change we make to it. License: CC BY 4.0 Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
793bba9
to
fee46fb
Compare
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
fee46fb
to
5cced6f
Compare
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
Ok, I think it should be ok to merge this now. |
@chriscool so it's not broken? cc @davidar |
Yes it is broken. The last test uses
You can also wait for someone to fix the problem, but I think it will be valuable to add some tests for this anyway. |
@chriscool ok sounds good. |
This is a test for issue #1582 (JSON encoding corrupts non-UTF-8 binary data).
But please don't merge this until the issue of the license of UTF-8-test.txt is fixed.The first patch adds a file that is CC BY 4.0 licensed, but after discussing with the author I think it is ok.